Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sdk-cpp: fixing hydra build #70882

Merged
merged 1 commit into from Oct 12, 2019
Merged

aws-sdk-cpp: fixing hydra build #70882

merged 1 commit into from Oct 12, 2019

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Oct 9, 2019

Motivation for this change

Making debug info conditional to fix hydra build.
The debug symbols alone are around ~1.8GB in size, which
makes the closure combined with the other two outputs
too large.

Failing hydra build: https://hydra.nixos.org/build/101616680#tabs-details
Hydra build from 19.03: https://hydra.nixos.org/build/101616680#tabs-details

Related: #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra @orivej

@edolstra
Copy link
Member

edolstra commented Oct 9, 2019

I think we can just remove separateDebugInfo from this package, no need for a debugVersion function argument. People who want debug symbols can use .overrideDerivation or whatever.

@ofborg ofborg bot requested a review from edolstra October 9, 2019 20:47
@d-goldin
aws-sdk-cpp: fixing hydra build
0ad35ab 
Removing debug info to fix hydra build.
The debug symbols alone are around ~1.8GB in size, which
makes the closure combined with the other two outputs
too large.
@d-goldin d-goldin force-pushed the conditional_debug_aws_sdk_cpp branch from 50df2ac to 0ad35ab Compare October 9, 2019 20:48
@joachifm joachifm merged commit 9c9020c into NixOS:master Oct 12, 2019
@d-goldin d-goldin deleted the conditional_debug_aws_sdk_cpp branch October 12, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-goldin @edolstra @joachifm