Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termite: passthru vte-ng #70776

Merged
merged 1 commit into from Oct 9, 2019
Merged

termite: passthru vte-ng #70776

merged 1 commit into from Oct 9, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Oct 8, 2019 •
edited

Motivation for this change

Home Manager termite module requires access to vte-ng. vte-ng got removed by b8ab859 so this PR restores it but as a passthru from termite itself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jtojnar

This was referenced Oct 8, 2019
Closed
Merged
kalbasit added a commit to kalbasit/shabka that referenced this pull request Oct 8, 2019
@kalbasit
external: fix home-manager broken by a nixpkgs commit
c1e5a67 
home-manager got broken because of
NixOS/nixpkgs@b8ab859
PR filed upstream:
- nix-community/home-manager#865
- NixOS/nixpkgs#70776
@kalbasit kalbasit merged commit 9dc7b25 into NixOS:master Oct 9, 2019
@kalbasit kalbasit deleted the expose-vte-ng branch October 9, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @jtojnar