Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/caddy: add tests #70778

Merged
merged 1 commit into from Oct 9, 2019
Merged

nixos/caddy: add tests #70778

merged 1 commit into from Oct 9, 2019

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change

I wanted to make sure Caddy works before working on moving my server infrastructure to NixOS. The test is based on nginx's test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rushmorem @fpletz @zimbatm

@zimbatm
Copy link
Member

zimbatm commented Oct 8, 2019

@GrahamcOfBorg test caddy

@zimbatm
Copy link
Member

zimbatm commented Oct 8, 2019 

undefined variable 'xfix' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/nixos/tests/caddy.nix:4:21

@KamilaBorowska
Copy link
Member Author

Hm, I guess I forgot to add myself to the maintainers list. I will fix this commit soon.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg test caddy

@KamilaBorowska
Copy link
Member Author

I guess I cannot run the test. Anyway highlighting maintainers again after a change.

cc @rushmorem @fpletz @zimbatm

@zimbatm
Copy link
Member

zimbatm commented Oct 9, 2019

@GrahamcOfBorg test caddy

@zimbatm zimbatm merged commit 7e1e138 into NixOS:master Oct 9, 2019
@zimbatm
Copy link
Member

zimbatm commented Oct 9, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @zimbatm