[Gecko Bug 1102175] Part 3 - Add reftests for altering <body> dynamically. #19608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 9, 2019
Differential Revision: https://phabricator.services.mozilla.com/D45580 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1102175 gecko-commit: 171c70db54de024df49059cb35bb6be68d5829a7 gecko-integration-branch: autoland gecko-reviewers: jfkthame
…t from the parent's. Without this patch, the `CHECK_BLOCK_AND_LINE_DIR` soft assertion in nsFloatManager can be triggered with wm-propagation-body-dynamic-change-002.html added in Part 3. Add the test as a crashtest because web-platform reftest doesn't seem to catch our soft assertions. Add reftests to verify that BFC bits are added to the child block if the parent and child has the same block-direction, but different sideways bit; also, add reftests to ensure that "text-orientation: sideways" doesn't add BFC bits. Differential Revision: https://phabricator.services.mozilla.com/D45912 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1102175 gecko-commit: c42855b477b170876a13ae32a60032d06698814c gecko-integration-branch: autoland gecko-reviewers: jfkthame
moz-wptsync-bot
force-pushed
the
gecko/1102175
branch
from
593c844
to
9372057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D45580
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1102175
gecko-commit: 004a0cb8af9fbbe84522d0506a1fdd132d51944c
gecko-integration-branch: autoland
gecko-reviewers: jfkthame