Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] nixos/networkmanager: default to internal #70884

Closed
wants to merge 1 commit into from
Closed

[19.09] nixos/networkmanager: default to internal #70884

wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

It's been the default since they switched to meson 0 and I don't think
we should diverge from upstream's defaults.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
nixos/networkmanager: default to internal
18b5af0 
It's been the default since they switched to meson [0] and I don't think
we should diverge from upstream's defaults.

[0]: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/1.18.2/meson_options.txt#L58
@worldofpeace
Copy link
Contributor Author

This should be the default for master already too, 1ff3a0c. Though it's really confusing, it appears all the other commits from that PR are on master but that one... (maybe a bad merge?)

@worldofpeace
Copy link
Contributor Author

I guess it's too late to fix this as it went under the radar.

@worldofpeace worldofpeace deleted the networkmanager-use-internal branch October 31, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace