Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update single-page tests to explicitly opt in to the feature #19578

Closed
jugglinmike opened this issue Oct 8, 2019 · 2 comments
Closed

Update single-page tests to explicitly opt in to the feature #19578

jugglinmike opened this issue Oct 8, 2019 · 2 comments
Assignees
@jugglinmike
Labels
testharness.js

Comments

@jugglinmike
Copy link
Contributor

In WPT RFC 28, we decided to introduce a new requirement for testharness.js tests which use the "single-page test" feature: they must enable the feature explicitly. To accomplish this, we first introduced an API for opting in--see gh-19449. Now, we plan to update all tests to use the new API.

(Once we resolve this issue, we'll update testharness.js to report a harness error for tests which do not define any subtests and which do not identify themselves as single-page tests.)
@jugglinmike jugglinmike self-assigned this Oct 8, 2019
@jugglinmike
Copy link
Contributor Author

We're done! Here are the relevant pull requests:

@jugglinmike jugglinmike mentioned this issue Oct 31, 2019
Merged
@jugglinmike
Copy link
Contributor Author

Following up in gh-20036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jugglinmike jugglinmike

Labels
testharness.js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @jugglinmike