Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfarranger: init at 1.3.1 #70784

Merged
merged 1 commit into from Oct 20, 2019
Merged

pdfarranger: init at 1.3.1 #70784

merged 1 commit into from Oct 20, 2019

Conversation

symphorien
Copy link
Member

Motivation for this change

The only gui app I know which enables to merge pdfs while displaying thumbnails for pages.
This is a fork of pdfshuffler, which was removed from nixpkgs because it was unmaintained.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

alexarice
alexarice approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work with nix-review on nixos

pkgs/applications/misc/pdfarranger/default.nix Outdated

doCheck = false; # no tests

meta = with stdenv.lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could import lib instead of stdenv.lib here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pkgs/applications/misc/pdfarranger/default.nix

meta = with stdenv.lib; {
inherit (src.meta) homepage;
description = "Merge or split pdf documents and rotate, crop and rearrange their pages using an interactive and intuitive graphical interface";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be too long but it's probably fine

@mmahut
Copy link
Member

mmahut commented Oct 10, 2019

@GrahamcOfBorg build pdfarranger

@Ekleog Ekleog merged commit ec76082 into NixOS:master Oct 20, 2019
@symphorien symphorien deleted the pdfarranger branch March 21, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@symphorien @mmahut @alexarice @Ekleog