Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnutls: fix test-ciphers-api.sh failure on aarch64 #70782

Merged
merged 1 commit into from Oct 15, 2019
Merged

gnutls: fix test-ciphers-api.sh failure on aarch64 #70782

merged 1 commit into from Oct 15, 2019

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Oct 8, 2019

Motivation for this change

The test-ciphers-api.sh test was failing. See https://gitlab.com/gnutls/gnutls/issues/764 for more info.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra @fpletz

@ofborg ofborg bot requested review from edolstra, lovek323 and fpletz October 8, 2019 20:14
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 9, 2019

This should target the staging branch given the amount of rebuilds.

Related: #70596

@wizeman wizeman changed the base branch from master to staging October 9, 2019 23:06
@wizeman
Copy link
Member Author

wizeman commented Oct 9, 2019

Rebased on staging and removed the comment as it doesn't look like utillinux will be removed as a gnutls make check dependency. Thanks!

@globin globin merged commit 7eccec6 into NixOS:staging Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@lovek323 lovek323 Awaiting requested review from lovek323

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wizeman @c0bw3b @globin