Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scc: init at 2.8.0 #70830

Merged
merged 1 commit into from
Oct 20, 2019
Merged

scc: init at 2.8.0 #70830

merged 1 commit into from
Oct 20, 2019
+28 −0

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Oct 9, 2019

Motivation for this change

Adding a fast LOC counter.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Sorry, something went wrong.

jonringer
jonringer reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the scripts executable, seems to be a dev tool

[nix-shell:/home/jon/.cache/nix-review/pr-70830]$ ls ./results/scc/bin/
scc  scripts

@jonringer
Copy link
Contributor

@GrahamcOfBorg build scc

jonringer
jonringer approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work

[3 built, 2 copied (3.3 MiB), 1.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70830
1 package were build:
scc

@jonringer jonringer merged commit 1f02f7c into NixOS:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sigma @jonringer