leo-editor: 5.7.3 -> 6.0, add Qt wrapping #70831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fx-chun
force-pushed
the
fix/leo/qt-wrapper
branch
from
8501618
to
ace4b7f
Compare
doronbehar
reviewed
Feb 23, 2020
| @@ -53,13 +54,15 @@ stdenv.mkDerivation rec { | |||
| makeWrapper ${python3.interpreter} $out/bin/leo \ | |||
| --set PYTHONPATH "$PYTHONPATH:$out/share/leo-editor" \ | |||
| --add-flags "-O $out/share/leo-editor/launchLeo.py" | |||
|
|
|||
| wrapQtApp $out/bin/leo | |||
There was a problem hiding this comment.
Is it wrapped twice eventually? I'm not too familiar with these wrapping methods but if the answer is yes, then you may want to try out using either of them or perhaps the makeWrapperArgs array.
| rev = version; | ||
| sha256 = "0ri6l6cxwva450l05af5vs1lsgrz6ciwd02njdgphs9pm1vwxbl9"; | ||
| rev = "v${version}"; | ||
| sha256 = "16hfhqxzkkzrv7mza24dypvm4zcarir6kw6fxvib2icrd12jyr6m"; | ||
| }; | ||
|
|
||
| dontBuild = true; |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
OP doesn't respond to review, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bump version to 6.0 and fix a crash on startup due to #65399.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @leonardoce @RamKromberg