Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: Don't print sensitive data to log on startup #70861

Merged
merged 1 commit into from Oct 11, 2019
Merged

nixos/gitlab: Don't print sensitive data to log on startup #70861

merged 1 commit into from Oct 11, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Oct 9, 2019

Motivation for this change

gitlab:db:configure prints the root user's password to stdout on successful setup, which means it will be logged to the journal. Silence this informational output. Errors are printed to stderr and will thus still be let through.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @flokli @fpletz

@talyz
nixos/gitlab: Don't print sensitive data to log on startup
dc29a45 
gitlab:db:configure prints the root user's password to stdout on
successful setup, which means it will be logged to the
journal. Silence this informational output. Errors are printed to
stderr and will thus still be let through.
@flokli flokli merged commit 1aad3ac into NixOS:master Oct 11, 2019
@flokli
Copy link
Contributor

flokli commented Oct 11, 2019

Backported to 19.09 in f0ed3df

@talyz talyz deleted the gitlab-silence-db-configure branch October 11, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @flokli @dasJ