Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dovecot: 2.3.7.2 -> 2.3.8 #70862

Merged
merged 2 commits into from
Oct 10, 2019
Merged

dovecot: 2.3.7.2 -> 2.3.8 #70862

merged 2 commits into from
Oct 10, 2019
+4 −4

Conversation

dotlambda
Copy link
Member

I assume this should not be backported?

Motivation for this change

https://dovecot.org/pipermail/dovecot-news/2019-October/000419.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Sorry, something went wrong.

@ofborg ofborg bot requested review from globin, fpletz, rickynils and peti October 9, 2019 15:30
@mmahut
Copy link
Member

mmahut commented Oct 10, 2019

@GrahamcOfBorg test dovecot

fpletz
fpletz approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should backport, i.e. due to fixes like:

  • v2.3.7 regression: If a folder only receives new mails without any
    other mail access, dovecot.index.log keeps growing forever and
    dovecot.index keeps being rewritten for every mail delivery.

@peti peti merged commit 668a8aa into NixOS:master Oct 10, 2019
@peti
Copy link
Member

peti commented Oct 10, 2019

I think we should backport.

👍

@dotlambda dotlambda deleted the dovecot-2.3.8 branch October 11, 2019 11:33
This was referenced Oct 11, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@globin globin

@rickynils rickynils

@peti peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @mmahut @peti @fpletz