Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 72531b1806df
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 356464388f7c
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Sep 25, 2019

  1. makeWrapper: Remove unused extraFlagsArray feature

    There is a bug in this feature: It allows extra arguments to leak in
    from the environment. For example:
    
      $ export extraFlagsArray=date
      $ man ls
    
    Note that you get the man page for date rather than for ls. This happens
    because 'man' happens to use a wrapper (to add groff to its PATH).
    
    An attempt to fix this was made in 5ae1857 in PR #19328 for
    issue #2537, but 1. That change didn't actually fix the problem because
    it addressed makeWrapper's environment during the build process, not the
    constructed wrapper script's environment after installation, and 2. That
    change was apparently accidentally lost when merged with 7ff6eec.
    
    Rather than trying to fix the bug again, we remove the extraFlagsArray
    feature, since it has never been used in the public repo in the ten
    years it has been available.
    
    wrapAclocal continues to use its own, separate flavor of extraFlagsArray
    in a more limited context. The analogous bug there was fixed in
    4d7d10d in 2011.
    chkno committed Sep 25, 2019
    Copy the full SHA
    a45b3ad View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. Merge pull request #69370 from chkno/no-extra-flags

    makeWrapper: Remove unused extraFlagsArray feature
    globin committed Oct 8, 2019
    Copy the full SHA
    3564643 View commit details
    Browse the repository at this point in the history