Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zulip: init at 4.0.0 #73094

Merged
merged 1 commit into from Nov 18, 2019
Merged

zulip: init at 4.0.0 #73094

merged 1 commit into from Nov 18, 2019

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 9, 2019

Motivation for this change

Add the Zulip chat client to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

New package.

@ryantm ryantm merged commit 74edb58 into NixOS:master Nov 18, 2019
@ryantm
Copy link
Member

ryantm commented Nov 18, 2019

thanks!

@jonafato jonafato deleted the zulip-4.0.0 branch November 18, 2019 02:09
@dotlambda dotlambda mentioned this pull request Sep 10, 2020
Closed
10 tasks
@kira-bruneau kira-bruneau mentioned this pull request Jun 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonafato @ryantm