Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero: 0.14.1.2 -> 0.15.0.0 #73162

Merged
merged 4 commits into from Nov 10, 2019
Merged

monero: 0.14.1.2 -> 0.15.0.0 #73162

merged 4 commits into from Nov 10, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Nov 10, 2019

Motivation for this change

Continuing the update in #73124. This PR takes care of monero-gui.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ehmry

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 10, 2019

I tested the connection of both monero-wallet-cli and monero-gui to a local daemon. Everything seems to be working.

@ofborg ofborg bot requested a review from ehmry November 10, 2019 15:03
ehmry
ehmry reviewed Nov 10, 2019
View reviewed changes
pkgs/applications/blockchains/monero-gui/default.nix
@@ -1,27 +1,27 @@
{ mkDerivation, lib, makeDesktopItem, fetchFromGitHub
{ stdenv, wrapQtAppsHook, makeDesktopItem, fetchFromGitHub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to pass stdenv? This package is imported with libsForQt5.callPackage, and its preferable to use the mkDerivation that it provides.

Copy link
Contributor Author

@rnhmjoj rnhmjoj Nov 10, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, however it seems mkDerivation will be no longer necessary/removed in the future... #71089.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, good to know, thanks.

@ehmry ehmry merged commit 84c44d8 into NixOS:master Nov 10, 2019
@rnhmjoj rnhmjoj mentioned this pull request Nov 10, 2019
Merged
10 tasks
@rnhmjoj rnhmjoj deleted the monero branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @ehmry @prusnak