nixos/calibre-server: Add address configuration #73110
Conversation
This commit introduces two new fields into the configuration of calibre-server, listenAddress and port. These allow the operator to configure the addresses that calibre should listen on, and the port it should bind to respectively. The default values here are copied from calibre itself, to avoid backwards compatibility issues or more complicated service configuration.
| default = "::"; | ||
| example = "127.0.0.1"; | ||
| description = '' | ||
| The interface on which to listen for connections. The value "::" will |
There was a problem hiding this comment.
Should we change it to The address on which to listen for connections
There was a problem hiding this comment.
Could do - I was keeping it inline with the upstream documentation for now, but don't feel strongly either way.
There was a problem hiding this comment.
OK. Thanks for the explanation.
|
Hey @domenkozar / @pSub - Was hoping that one of you may be able to take a look at this soon? Thanks! |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
@endocrimes PING |
stale
bot
removed
the
2.status: stale
stale
bot
added
the
2.status: stale
|
@endocrimes Any chance of solving the conflict? Thanks! |
stale
bot
removed
the
2.status: stale
|
@AndersonTorres Why are you closing this issue? I tried to resolve the conflicts yesterday. Somehow ofborg fail and I wanted to investigate this weekend. |
|
Two years and the original poster ignored the pings and replies. I closed it because it was abandoned. If anyone is interested, certainly it can be reopened. |
This commit introduces two new fields into the configuration of calibre-server, listenAddress and port. These allow the operator to configure the addresses that calibre should listen on, and the port it should bind to respectively.
The default values here are copied from calibre itself, to avoid backwards compatibility issues or more complicated service configuration.
Motivation for this change
calibre defaults to listening on port 8080 on all interfaces, which isn't ideal in almost any configuration outside of developing calibre itself. Exposing this configuration lets people run calibre more reasonably.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @domenkozar @pSub @AndersonTorres