Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
broken in nixpkgs at version 0.35, cf.
ncmpc: 0.35 -> 0.36 #73000 (comment) )
Things done
sandbox
innix.conf
on non-NixOS linux)Sandboxing was enabled during builds.
On my workstation (nixos 19.09) the tests fail with this output:
No
results/log.html
is generated. Obviously an error, butthe test fails just the same when I revert the commit.
Tested compilation of all pkgs that depend on this change using
nix-shell -p nix-review --run "nix-review wip"
[×] Tested execution of all binary files (usually in
./result/bin/
)[×] Determined the impact on package closure size (by running
nix path-info -S
before and after)/nix/store/92awbqvshidddpj4shsbb6xxyykpfygi-mpd-0.20.23 1734392 406571600
/nix/store/3v2yvfi5zw77kvxa90c9s2y3chx544vk-mpd-0.21.16 1926736 197168440
Ensured that relevant documentation is up to date
[×] Fits CONTRIBUTING.md.
Notify maintainers
cc @