Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage-access-api] make idlharness.js test tentative with external IDL #20165

Merged
merged 1 commit into from Feb 13, 2020

Conversation

foolip
Copy link
Member

@foolip foolip commented Nov 7, 2019

There is already precedent for this style with
trusted-types.tentative.idl and xslt.tentative.idl.

The [OverrideBuiltins] extended attribute was not kept because it's
not in the spec pull request and it also isn't used by idlharness.js.

There is already precedent for this style with
trusted-types.tentative.idl and xslt.tentative.idl.

The `[OverrideBuiltins]` extended attribute was not kept because it's
not in the spec pull request and it also isn't used by idlharness.js.
@foolip
Copy link
Member Author

foolip commented Jan 23, 2020

Ping @Brandr0id

@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the foolip/storage-access-api-idlharness branch January 24, 2020 18:06
@gsnedders gsnedders restored the foolip/storage-access-api-idlharness branch January 24, 2020 18:48
@Hexcles Hexcles reopened this Jan 24, 2020
Copy link
Member

@Brandr0id Brandr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @foolip , LGTM

@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-20165 February 7, 2020 02:48 Abandoned
@foolip foolip merged commit fc41453 into master Feb 13, 2020
@foolip foolip deleted the foolip/storage-access-api-idlharness branch February 13, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants