Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage-access-api] expand on META.yml #20164

Merged
merged 1 commit into from Nov 28, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Nov 7, 2019

No description provided.

@foolip
Copy link
Member Author

foolip commented Nov 7, 2019

@ehsan @johnwilander, I'm proposing these changes based on @Brandr0id saying in email that you're the primary contacts for Gecko and WebKit. I won't merge this without your explicit approval, and if you do want to review I'll make sure you're in the reviewers team and have write access before I merge this.

Copy link
Member

@Brandr0id Brandr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnwilander
Copy link

Looks good.

@foolip
Copy link
Member Author

foolip commented Nov 8, 2019

@johnwilander you have a pending invitation to the org and reviewers team, I think you can see a banner at the top of https://github.com/web-platform-tests or find it in your inbox. After you join, see https://github.com/orgs/web-platform-tests/teams/reviewers/discussions for some tips to avoid excessive mail spam, and some email filter tips.

@ehsan
Copy link
Contributor

ehsan commented Nov 21, 2019

Thanks, looks good here as well. Apologies for the delay.

@foolip
Copy link
Member Author

foolip commented Nov 28, 2019

Thanks all, I'll merge now.

@foolip foolip merged commit b29e08a into master Nov 28, 2019
@foolip foolip deleted the foolip/more-storage-access-api-meta branch November 28, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants