Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: fixing cve patch name #73008

Merged
merged 1 commit into from
Nov 8, 2019
Merged

sqlite: fixing cve patch name #73008

merged 1 commit into from
Nov 8, 2019
+1 −1

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Nov 7, 2019

Motivation for this change

To make vulnix and similar tooling recognize the patch
correctly. This is only needed for 19.09 and only to make sure that vulnix does not raise
this issue again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andir

Sorry, something went wrong.

@ofborg ofborg bot requested review from edolstra and np November 7, 2019 23:44
@veprbl
Copy link
Member

veprbl commented Nov 8, 2019

This needs to target staging-19.09 branch

@d-goldin d-goldin changed the base branch from release-19.09 to staging-19.09 November 8, 2019 09:52
@d-goldin
sqlite: fixing cve patch name

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: F3510FE5691629A1
Learn about vigilant mode
40de607 
To make vulnix and similar tooling recognize the patch
correctly.
@d-goldin d-goldin force-pushed the fix_sqlite_cve_patch_name branch from 5b6d4b6 to 40de607 Compare November 8, 2019 09:54
@andir andir merged commit 1eebd6f into NixOS:staging-19.09 Nov 8, 2019
@d-goldin d-goldin deleted the fix_sqlite_cve_patch_name branch November 8, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

@np np

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-goldin @veprbl @andir