Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepassxc: add additional cmake options #73092

Merged
merged 1 commit into from Nov 10, 2019
Merged

keepassxc: add additional cmake options #73092

merged 1 commit into from Nov 10, 2019

Conversation

contrun
Copy link
Contributor

@contrun contrun commented Nov 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonafato

This patch adds support for touchid on macos and libsecret support on linux. The flags are taken from here.

@ofborg ofborg bot requested a review from jonafato November 9, 2019 04:51
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 10, 2019

Checking darwin build:
@GrahamcOfBorg build keepassxc

c0bw3b
c0bw3b approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darwin failure unrelated (libmicrohttpd already failing on Hydra for this platform)

@c0bw3b c0bw3b merged commit f16ee99 into NixOS:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

@jonafato jonafato Awaiting requested review from jonafato

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@contrun @c0bw3b @bjornfor