Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protolock: 0.14.1 -> 0.15.0 #73093

Merged
merged 1 commit into from Dec 4, 2019
Merged

protolock: 0.14.1 -> 0.15.0 #73093

merged 1 commit into from Dec 4, 2019

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Nov 9, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kalbasit

@ofborg ofborg bot requested a review from kalbasit November 9, 2019 05:38
@risicle
Copy link
Contributor

risicle commented Nov 9, 2019

Builds for me, macos 10.13

@groodt
Copy link
Contributor Author

groodt commented Nov 14, 2019

Ping @kalbasit

@groodt
Copy link
Contributor Author

groodt commented Nov 20, 2019

Anything more you need @kalbasit ?

@groodt
Copy link
Contributor Author

groodt commented Dec 1, 2019

Hi @kalbasit

I appreciate you must be very busy. Is there somebody else who you might be able to delegate this to?

@groodt groodt mentioned this pull request Dec 3, 2019
Merged
10 tasks
@marsam marsam merged commit aa1d254 into NixOS:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@groodt @risicle @marsam