Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: 0.30.1 -> 0.31.1 #73031

Merged
merged 1 commit into from
Nov 9, 2019
Merged

crystal: 0.30.1 -> 0.31.1 #73031

merged 1 commit into from
Nov 9, 2019
+9 −1

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Nov 8, 2019 •
edited
Loading

Motivation for this change

https://crystal-lang.org/2019/09/23/crystal-0.31.0-released.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peterhoeg @infinisil

Sorry, something went wrong.

@peterhoeg
Copy link
Member

Do you mind trying to see if we can build it using our 0.30 ?

According to upstream, $current can be compiled by $current - 1, so we could ideally dump the binary bootstrapper and use our version. Self-hosted ftw!

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 8, 2019
@ofborg ofborg bot requested review from david50407 and peterhoeg November 8, 2019 09:39
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 8, 2019
@manveru
Copy link
Contributor Author

manveru commented Nov 8, 2019

@peterhoeg done, seems to work without issues.

@infinisil infinisil merged commit e9e7210 into NixOS:master Nov 9, 2019
@manveru manveru deleted the crystal-0.31.1 branch December 12, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david50407 david50407

@peterhoeg peterhoeg

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manveru @peterhoeg @david50407 @infinisil