Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent potential timeout results in 2 MathML tests: #20179

Merged
merged 1 commit into from Nov 8, 2019

Conversation

fred-wang
Copy link
Contributor

cc @rwlbuis

  • css-inline-style-dynamic.tentative.html:
    Verify that MathMLElement.style is defined before using it. Add a
    feature detection for mspace to avoid false positive.

  • href-click-3.html: Handle test_driver's click failure and perform a
    second click with a 'bad' HTML target. If href is supported, the test
    would have completed before the 'bad' handler is called. Otherwise,
    the test will complete in that 'bad' handler.

closes w3c/mathml#167

- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes w3c/mathml#167
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fred-wang fred-wang merged commit 5dde827 into master Nov 8, 2019
@fred-wang fred-wang deleted the mathml-timeout branch November 8, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible timeout with css-inline-style-dynamic.tentative.html and href-click-3.html
3 participants