Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: keep multiple version #73039

Merged
merged 1 commit into from Nov 8, 2019
Merged

rust: keep multiple version #73039

merged 1 commit into from Nov 8, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Nov 8, 2019

Motivation for this change

Firefox 70.0.1 and Thunderbird 68.2.2 require older version of rustc.
#72006
#73023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @madjar, @cstrahan, @globin, @Havvy, @edolstra

@taku0
rust: keep multiple version.
97f20c3 
Firefox 70.0.1 and Thunderbird 68.2.2 require older version of rustc.
@taku0 taku0 requested review from LnL7 and Mic92 as code owners November 8, 2019 12:16
This was referenced Nov 8, 2019
Merged
Closed
@d-goldin
Copy link
Contributor

d-goldin commented Nov 8, 2019 •
edited

Gave a nix-review run and briefly tested thunderbird on nixos. Worked out fine.

@edolstra edolstra merged commit e4a6fba into NixOS:master Nov 8, 2019
@taku0 taku0 mentioned this pull request Nov 8, 2019
Merged
10 tasks
@nmattia nmattia mentioned this pull request Jan 24, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @d-goldin @edolstra