Switch to std::uncaught_exceptions #3214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns the number of uncaught exceptions. std::uncaught_exception just returned whether there were any uncaught exceptions. c++17 deprecated it and c++20 will remove it. GCC 9 warns that the function is deprecated. std::uncaught_exceptions() can be > 1 if all exceptions are caught before they propagate to a stack unwind. E.g. if a first exception occurs and a destructor runs as part of the stack unwind, then that destructor may cause additional exceptions to be thrown as long as they are caught before that destructor returns. I'm unsure if this can occur in nix, but I handled it by recording the first count in the constructor and comparing it to the count in the destructor. That way the object can determine whether the exception was thrown during its lifetime.
|
See 93b1ce1. |
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns the number of uncaught exceptions. std::uncaught_exception
just returned whether there were any uncaught exceptions. c++17
deprecated it and c++20 will remove it. GCC 9 warns that the function is
deprecated.
std::uncaught_exceptions() can be > 1 if all exceptions are caught
before they propagate to a stack unwind. E.g. if a first exception
occurs and a destructor runs as part of the stack unwind, then that
destructor may cause additional exceptions to be thrown as long as they
are caught before that destructor returns.
I'm unsure if this can occur in nix, but I handled it by recording the
first count in the constructor and comparing it to the count in the
destructor. That way the object can determine whether the exception was
thrown during its lifetime.