Add more scroll to text WPTs #20184
Merged
Add more scroll to text WPTs #20184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 8, 2019
Adds more web platform tests for scroll to text: - Combination of non-text directive and text directive - Scroll second text directive into view if first doesn't match - Matching shadow DOM - Don't scroll to hidden text - Text that requires a horizontal scroll into view - Also fixed non-ASCII test case (and changed to Japanese example) Change-Id: Id7e21a185897267dc565b19adc7bfdfb5fe70974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903624 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714381}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1903624
branch
from
cb1a9d4
to
b1ddcf9
Compare
|
One test is flaky-timeout on google-chrome-unstable (9/10 FAIL, 1/10 TIMEOUT). Pinged the CL (https://chromium-review.googlesource.com/c/chromium/src/+/1903624). |
|
I've filed #20269 and will admin merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more web platform tests for scroll to text:
Change-Id: Id7e21a185897267dc565b19adc7bfdfb5fe70974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903624
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714381}