Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null-dereference Read in blink::TransformOperations::ApplyRemaining fix #20183

Merged
merged 1 commit into from Nov 21, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 8, 2019

null_ptr get inserted into the Interpolatedtransform as from_ops via Blend function.
This would cause the functions that call the Apply in Interpolatedtransform class to crash.
Added the test case for testing Interpolatedtransform Blend.

Bug: 998938
Change-Id: I34a2e44d0fadf1c0ea848167714adbd0aa656910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887235
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717829}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1887235 branch 4 times, most recently from 2f41294 to d13565c Compare November 12, 2019 18:52
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1887235 branch 6 times, most recently from 3073c17 to 5e240e4 Compare November 21, 2019 18:25
null_ptr get inserted into the Interpolatedtransform as from_ops via Blend function.
This would cause the functions that call the Apply in Interpolatedtransform class to crash.
Added the test case for testing Interpolatedtransform Blend.

Bug: 998938
Change-Id: I34a2e44d0fadf1c0ea848167714adbd0aa656910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887235
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717829}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants