Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libco-canonical: fix pkgconfig includedir #73020

Merged
merged 1 commit into from Nov 8, 2019
Merged

libco-canonical: fix pkgconfig includedir #73020

merged 1 commit into from Nov 8, 2019

Conversation

lodi
Copy link
Contributor

@lodi lodi commented Nov 8, 2019

Motivation for this change

libco.pc (pkgconfig file) was incorrectly setting includedir to the "out" path, instead of the "dev" path.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @wucke13

@lodi
libco-canonical: fix pkgconfig includedir
32497cf 
Patched Makefile so that includedir correctly points to "dev" output
instead of "out" output.
@ofborg ofborg bot requested a review from wucke13 November 8, 2019 06:30
wucke13
wucke13 approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@wucke13 wucke13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@matthewbauer matthewbauer merged commit 85a94a2 into NixOS:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wucke13 wucke13 wucke13 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lodi @wucke13 @matthewbauer @Janik-Haag