Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roundcube: 1.3.10 -> 1.4.0 #73169

Merged
merged 1 commit into from Nov 15, 2019
Merged

roundcube: 1.3.10 -> 1.4.0 #73169

merged 1 commit into from Nov 15, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 10, 2019

Motivation for this change

https://roundcube.net/news/2019/11/09/roundcube-1.4.0-released

  • curl cmd in the test can fail as roundcube returns a http/401 if
    unauthorized (and we're explicitly requesting the login form). By
    checking if the persistent_login plugin is loaded, the assertion is
    still valid.

  • Use $argv[0] to determine install path in the installer script. I'm
    not exactly sure why, but it seems as __DIR__ now resolves symlinks
    which breaks the installer if roundcube is in a buildEnv with
    third-party plugins.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
roundcube: 1.3.10 -> 1.4.0
d75c296 
https://roundcube.net/news/2019/11/09/roundcube-1.4.0-released

* `curl` cmd in the test can fail as roundcube returns a http/401 if
  unauthorized (and we're explicitly requesting the login form). By
  checking if the `persistent_login` plugin is loaded, the assertion is
  still valid)

* Use `$argv[0]` to determine install path in the installer script. I'm
  not exactly sure why, but it seems as `__DIR__` now resolves symlinks
  which breaks the installer if roundcube is in a `buildEnv` with
  third-party plugins.
@ofborg ofborg bot requested review from globin and Vskilet November 10, 2019 18:04
@seppeljordan
Copy link
Contributor

Hey, I checked out the PR and ran the NixOS test roundcube.nix and it worked fine.

@Vskilet
Copy link
Contributor

Vskilet commented Nov 10, 2019

I have an error at the moment on the Roundcube setup

Executing database schema update.
Updating database schema (2013011000)... [FAILED]
ERROR: Error in DDL upgrade 2013011000: [7] ERROR:  relation "rcsystem" already exists
Main process exited, code=exited, status=1/FAILURE

I'm going to look in detail tomorrow

Thanks for the PR

@Ma27
Copy link
Member Author

Ma27 commented Nov 10, 2019

Hmm, would you mind sharing your configuration (and which version of nixpkgs are you using?).

I deloyed this patch to a machine which uses release-19.09 and I didn't encounter any migration issues.

@Vskilet
Copy link
Contributor

Vskilet commented Nov 11, 2019

So I move from roundcube 1.3.10 to 1.4.0 with a 19.09-small version of nixpkgs. It's seem that this type of error already occured roundcube/roundcubemail#6034
So I search on database update script side. I'll keep you informed.

@aanderse
Copy link
Member

Any updates?

@globin globin merged commit ab99684 into NixOS:master Nov 15, 2019
@Ma27 Ma27 deleted the bump-roundcube branch November 15, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@Vskilet Vskilet Awaiting requested review from Vskilet

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ma27 @seppeljordan @Vskilet @aanderse @globin