Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caffeine-ng: fix paths in desktop files #73123

Merged
merged 1 commit into from Nov 11, 2019
Merged

caffeine-ng: fix paths in desktop files #73123

merged 1 commit into from Nov 11, 2019

Conversation

symphorien
Copy link
Member

Motivation for this change

xdg autostart desktop files were not installed, and normal desktop files contained wrong paths (/usr/bin/caffeine).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @marzipankaiser

@ofborg ofborg bot requested a review from marzipankaiser November 9, 2019 17:46
marzipankaiser
marzipankaiser approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@marzipankaiser marzipankaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thank you for your work.

@c0bw3b c0bw3b merged commit 40f1983 into NixOS:master Nov 11, 2019
@symphorien symphorien deleted the caffeine-autostart branch March 21, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marzipankaiser marzipankaiser marzipankaiser approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @marzipankaiser @c0bw3b