Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero: 0.14.1.0 -> 0.15.0.0 #73124

Closed
wants to merge 1 commit into from
Closed

monero: 0.14.1.0 -> 0.15.0.0 #73124

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 9, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ehmry @rnhmjoj

@ofborg ofborg bot requested review from rnhmjoj and ehmry November 9, 2019 17:58
@prusnak
Copy link
Member Author

prusnak commented Nov 9, 2019

@GrahamcOfBorg build monero

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 10, 2019

Ok, monero looks all right but the GUI didn't build though. I'd rather update both package at the same time to avoid breaking monero-gui

@rnhmjoj rnhmjoj mentioned this pull request Nov 10, 2019
Merged
10 tasks
@ehmry
Copy link
Contributor

ehmry commented Nov 10, 2019

Merged at 84c44d8.

@ehmry ehmry closed this Nov 10, 2019
@prusnak prusnak deleted the monero branch November 10, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @rnhmjoj @ehmry