nixos/networking.nix: make /etc/netgroup empty #68671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscd complains when we say to cache /etc/netgroup but it doesn’t actually exist. To silence these (apparently harmless) warning, just make /etc/netgroup empty on NixOS Fixes NixOS#68603
Mic92
reviewed
Sep 13, 2019
| @@ -37,6 +37,10 @@ in | |||
| ###### implementation | |||
|
|
|||
| config = mkIf cfg.enable { | |||
| system.activationScripts.netgroup = '' | |||
| touch /etc/netgroup | |||
There was a problem hiding this comment.
systemd.tmpfiles.rules is preferred here. If we ever want to manage this file or a user would it not be better to use environment.etc."netgroup"?
There was a problem hiding this comment.
My understanding was it could be generated by some tools similar to how resolv.conf works. But unclear on that, and probably need someone who actually uses this file to provide some input. This was just the easiest way to silence that warning.
There was a problem hiding this comment.
Something like following should work too:
systemd.tmpfiles.rules = [ "f /etc/netgroup" ];
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nscd complains when we say to cache /etc/netgroup but it doesn’t
actually exist. To silence these (apparently harmless) warning, just
make /etc/netgroup empty on activation.
Fixes #68603
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @