Remove reliance on external information #34
Merged
+65
−2,212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anchoring ourselves to an external project, at this point, is not feasible. This does not allow us to explore making better use of the capabilities of nix. Though, a mechanism using third-party resources, like the postmarketOS device information, is something that is desirable. The difference is that it would need to *import* the information in the format used by mobile-nixos, rather than mobile-nixos importing the information from a "data dump".
samueldr
force-pushed
the
feature/remove-external-info
branch
from
295f6ed to
0f648ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short story is that relying on external data limits us in some ways. What we'll do, in the future, is add a helper to import the data into whatever format we are using at the time.
That is, until we work with the other projects (not only postmarketOS) and figure out a good way to share the relevant information.