Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfn-lint: propagate setuptools #73065

Merged
merged 1 commit into from Nov 9, 2019
Merged

cfn-lint: propagate setuptools #73065

merged 1 commit into from Nov 9, 2019

Conversation

rtimush
Copy link
Contributor

@rtimush rtimush commented Nov 8, 2019

Motivation for this change

cfn-lint fails:

Traceback (most recent call last):
  File "/nix/store/xmg2xz7n128fwhl9hw06hp1qf3x42cs7-python3.7-cfn-lint-0.24.5/bin/.cfn-lint-wrapped", line 6, in <module>
    from cfnlint.__main__ import main
  File "/nix/store/xmg2xz7n128fwhl9hw06hp1qf3x42cs7-python3.7-cfn-lint-0.24.5/lib/python3.7/site-packages/cfnlint/__init__.py", line 27, in <module>
    import cfnlint.helpers
  File "/nix/store/xmg2xz7n128fwhl9hw06hp1qf3x42cs7-python3.7-cfn-lint-0.24.5/lib/python3.7/site-packages/cfnlint/helpers.py", line 32, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

do you mind rebasing this onto staging? it causes a lot of rebuilds

@rtimush rtimush changed the base branch from master to staging November 9, 2019 12:57
@rtimush
Copy link
Contributor Author

rtimush commented Nov 9, 2019

@jonringer sure, rebased and retargeted the PR (not sure though if it's what you meant).

@ofborg ofborg bot removed the 6.topic: emacs label Nov 9, 2019
@FRidh FRidh merged commit dfac4a0 into NixOS:staging Nov 9, 2019
@jonringer
Copy link
Contributor

For PRs which cause more than ~100 rebuilds they should be made against staging so that people on master don't have to wind up in a situation where they need to rebuild a lot of packages just to do their dev.

https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch

@jonringer
Copy link
Contributor

python packages are "light" in compute resources, but I was afraid it was closer to the 500ish rebuilds range

@rtimush
Copy link
Contributor Author

rtimush commented Nov 9, 2019

Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@alyssais alyssais Awaiting requested review from alyssais

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rtimush @jonringer @FRidh @Janik-Haag