Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsproxy: init at 0.20.0 #73107

Merged
merged 2 commits into from Nov 18, 2019
Merged

dnsproxy: init at 0.20.0 #73107

merged 2 commits into from Nov 18, 2019

Conversation

contrun
Copy link
Contributor

@contrun contrun commented Nov 9, 2019

Init dnsproxy

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit November 9, 2019 11:05
@risicle
Copy link
Contributor

risicle commented Nov 9, 2019

Seems to WFM, macos 10.13

@contrun contrun force-pushed the init-dnsproxy branch 2 times, most recently from 8e80570 to b4f4c63 Compare November 18, 2019 02:32
Lassulus
Lassulus approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, started the dnsproxy and threw a query against it

@Lassulus Lassulus merged commit 5de7286 into NixOS:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@contrun @risicle @Lassulus