New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sequoia: 0.10.0 -> 0.11.0 #73104
sequoia: 0.10.0 -> 0.11.0 #73104
Conversation
Hey, thank you for the update! Can you tell me more on how this fixes #70646? |
Unfortunately, |
Do you happen to be using # Use an a tmpdir with unlimited space (as opposed to /tmp)
systemd.services."nix-daemon".environment.TMPDIR = "/nix/tmp"; BTW, my cachix has a build of this derivation.
TBH, and @worldofpeace should be cc'd, I don't know why it failed on hydra in the first place, as it always builds locally. it seems to be only a matter of resources, hence the removed |
Failure on macos 10.13: https://gist.github.com/risicle/debf821acd7586f30ce21842dd6ab2f4 |
Hmm, interesting, did you try to build |
Both gave a similar error. |
Could you please disable the tests |
Possibly telling: https://gist.github.com/risicle/aa6fb3ccd0f962540c9be0b6cb12635c |
I guess failing on macos is a different issue. |
So @worldofpeace shall we disable tests for MacOS only in the meantime? |
The tests aren't the problem on macos. |
Well I have no way to debug this for MacOS. what perplexes me though is that the 2 gists you've published indicate a different issue every time. What was the different between the 2 attempts? |
The first time |
I see. If no MacOS user would like to fix this issue, then I'm marking the package as broken only for MacOS. See 3a7bbb6 . |
@doronbehar Yeah, it's looking like a bit of a hassle. We can just do as I suggested as an alternative in a09e3e2, which is to drop that commit and just disable checkPhase. We can communicate with upstream. |
@worldofpeace what do you think about @curiousleo's suggestion:
? |
BTW @worldofpeace setting the ulimit fails the build locally for me, with:
Pushed a revert. |
(I've just noticed, but your commit message and PR title indicates the upgrade from 0.10.0 to 0.11.1, but the new version in the commit is 0.11.0 ) 😛 |
Disable check on Darwin.
c5688bb
to
1dbcd8f
Compare
Thanks @minijackson :) |
Motivation for this change
Closes #70646.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @minijackson