Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audacity: use gtk version passed through wxwidgets #73055

Merged
merged 1 commit into from Nov 13, 2019
Merged

audacity: use gtk version passed through wxwidgets #73055

merged 1 commit into from Nov 13, 2019

Conversation

wakira
Copy link
Member

@wakira wakira commented Nov 8, 2019 •
edited

Make possible to build against gtk3, which is useful for HiDPI displays.

Motivation for this change

audacity looks pretty bad with HiDPI scaling on gtk2. This change removes hard dependency on gtk2, which should prevent build failure when wxWidgets is overridden to build against gtk3.

* The option to use gtk3 is not very obvious. Maybe we should use an alternative approach, such as a withGtk3 option that overrides the gtk version in wxWidgets?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @the-kenny

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2019

Hello and welcome around here @wakira ; thanks for your first contribution to nixpkgs :)

Related work in #73145
but that doesn't block this PR.

@wakira
audacity: use gtk version passed through wxwidgets
ecf124f 
Make possible to build against gtk3, which is useful for HiDPI displays.
@c0bw3b c0bw3b merged commit 967d294 into NixOS:master Nov 13, 2019
@c0bw3b c0bw3b mentioned this pull request Nov 13, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wakira @c0bw3b @Janik-Haag