Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.black: 19.03b0 -> 19.10b0 #73053

Merged
merged 3 commits into from Nov 9, 2019
Merged

python3Packages.black: 19.03b0 -> 19.10b0 #73053

merged 3 commits into from Nov 9, 2019

Conversation

kwohlfahrt
Copy link
Contributor

@kwohlfahrt kwohlfahrt commented Nov 8, 2019 •
edited

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sveitser

@jonringer
Copy link
Contributor

quite a bit of regressions, please look at the failed packages, pytest-black is the most important:

[10 built (8 failed), 186 copied (436.3 MiB), 184.2 MiB DL]
error: build of '/nix/store/ivl1whsa1c6acsq6hnbf854cndwl054m-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73053
1 package are marked as broken and were skipped:
bareos

26 package failed to build:
ceph ceph-client datasette fava flexget libceph mnemosyne python37Packages.bugseverywhere python37Packages.cheroot python37Packages.cherrypy python37Packages.portend python37Packages.pyalgotrade python37Packages.pytest-black python37Packages.ws4py python37Packages.zerobin python38Packages.bugseverywhere python38Packages.cheroot python38Packages.cherrypy python38Packages.datasette python38Packages.portend python38Packages.pyalgotrade python38Packages.pyls-black python38Packages.pytest-black python38Packages.ws4py python38Packages.zerobin sambaFull

8 package were build:
git-revise python37Packages.black python37Packages.pyls-black python37Packages.stumpy python37Packages.uarray python38Packages.black python38Packages.git-revise python38Packages.uarray

@kwohlfahrt
pytest-black: patch black dependency
b8669db 
This change is pending upstream in NixOS#29, but it is stale.
@kwohlfahrt
Copy link
Contributor Author

pytest-black pins specifically 19.03b. There's a (stale) PR upstream but no movement in months: shopkeep/pytest-black#29

pytest-black pins the version for reasons to do with Pipenv not playing nice with prerelease packages. I've patched this, since it shouldn't affect us - should I also push for this upstream?

@kwohlfahrt
Copy link
Contributor Author

kwohlfahrt commented Nov 9, 2019 •
edited

@jonringer could you have another look? With the proposed patches, none of the remaining failures look black-related. I will open a PR upstream for portend.

4 package failed to build:
datasette fava python38Packages.datasette python38Packages.pyls-black

@kwohlfahrt kwohlfahrt mentioned this pull request Nov 9, 2019
Closed
@jonringer jonringer mentioned this pull request Nov 9, 2019
Merged
10 tasks
@jonringer
Copy link
Contributor

failures seem to be unrelated to package bump

jonringer
jonringer approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

failures are unrelated to this package bump, I'm making PRs to fix them

[32 built (7 failed), 587 copied (2080.0 MiB), 487.4 MiB DL]
error: build of '/nix/store/p5jkg3axp157jw1yvw06wwdff1skj8rq-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73053
1 package are marked as broken and were skipped:
bareos

4 package failed to build:
datasette fava python38Packages.datasette python38Packages.pyls-black

30 package were build:
ceph ceph-client flexget git-revise libceph mnemosyne python37Packages.black python37Packages.bugseverywhere python37Packages.cheroot python37Packages.cherrypy python37Packages.portend python37Packages.pyalgotrade python37Packages.pyls-black python37Packages.pytest-black python37Packages.stumpy python37Packages.uarray python37Packages.ws4py python37Packages.zerobin python38Packages.black python38Packages.bugseverywhere python38Packages.cheroot python38Packages.cherrypy python38Packages.git-revise python38Packages.portend python38Packages.pyalgotrade python38Packages.pytest-black python38Packages.uarray python38Packages.ws4py python38Packages.zerobin sambaFull

@jonringer jonringer merged commit 62e927d into NixOS:master Nov 9, 2019
@kwohlfahrt kwohlfahrt deleted the black branch December 18, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwohlfahrt @jonringer