Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: 20191001_a -> 20191201_a #73041

Merged
merged 2 commits into from Dec 4, 2019
Merged

gildas: 20191001_a -> 20191201_a #73041

merged 2 commits into from Dec 4, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented Nov 8, 2019 •
edited

Motivation for this change

Update gildas to the latest upstream version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bzizou

@ofborg ofborg bot requested a review from bzizou November 8, 2019 12:44
@bzizou
Copy link
Contributor

bzizou commented Nov 12, 2019

OK for me

@smaret smaret changed the title gildas: 20191001_a -> 20191101_a gildas: 20191001_a -> 20191201_a Dec 2, 2019
@ofborg ofborg bot requested a review from bzizou December 2, 2019 11:55
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/75

@c0bw3b c0bw3b merged commit c108aca into NixOS:master Dec 4, 2019
@smaret smaret deleted the gildas-20191101_a branch December 4, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzizou bzizou bzizou approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smaret @bzizou @nixos-discourse @c0bw3b