Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.datasette: 0.29.3 -> 0.30.2 #73127

Merged
merged 1 commit into from Nov 11, 2019
Merged

python3Packages.datasette: 0.29.3 -> 0.30.2 #73127

merged 1 commit into from Nov 11, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 9, 2019 •
edited

Motivation for this change

noticed it was broken when reviewing #73053

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

python38 broken by python38Packages.websockets:

[0 built (3 failed), 1 copied (0.5 MiB), 0.1 MiB DL]
error: build of '/nix/store/i5isg1kam2ggc0psa769krvp2j4bnd9c-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73127
1 package failed to build:
python38Packages.datasette

1 package were build:
datasette

@jonringer jonringer requested a review from FRidh as a code owner November 9, 2019 18:40
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.datasette

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.datasette

pushed darwin fix

@jonringer jonringer mentioned this pull request Nov 9, 2019
Merged
10 tasks
@ofborg ofborg bot requested a review from costrouc November 9, 2019 18:55
@jonringer jonringer changed the title python3Packages.datasett: 0.29.3 -> 0.30.2 python3Packages.datasette: 0.29.3 -> 0.30.2 Nov 9, 2019
@jonringer
Copy link
Contributor Author

fixed commit message

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.datasette

@jonringer
Copy link
Contributor Author

darwin failure related to black package

@jonringer jonringer merged commit e9453fc into NixOS:master Nov 11, 2019
@jonringer jonringer deleted the bump-datasette branch February 13, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer