Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.websockets: 8.0.2 -> 8.1 #73128

Merged
merged 1 commit into from Nov 11, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 9, 2019

Motivation for this change

noticed the python38 build was broken when reviewing #73127

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor Author

[16 built (7 failed), 32 copied (73.9 MiB), 15.0 MiB DL]
error: build of '/nix/store/xw7zhw57cq60rwcd2sfbf4d75093fn2a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73128
2 package are marked as broken and were skipped:
python37Packages.discordpy python38Packages.discordpy

12 package failed to build:
datasette python37Packages.fastapi python37Packages.hbmqtt python37Packages.sentry-sdk python38Packages.datasette python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.fastapi python38Packages.hbmqtt python38Packages.sanic python38Packages.starlette python38Packages.uvicorn

15 package were build:
gdbgui grab-site python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.websockets python38Packages.flask-socketio python38Packages.python-engineio python38Packages.python-socketio python38Packages.websockets

failures are broken on master

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build gdbgui grab-site python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.websockets python38Packages.flask-socketio python38Packages.python-engineio python38Packages.python-socketio python38Packages.websockets

@jonringer jonringer merged commit a0476bb into NixOS:master Nov 11, 2019
@jonringer jonringer deleted the bump-websockets branch November 11, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant