Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] melpa-packages: 2019-10-25 #73071

Merged
merged 1 commit into from Nov 9, 2019
Merged

[19.09] melpa-packages: 2019-10-25 #73071

merged 1 commit into from Nov 9, 2019

Conversation

benley
Copy link
Member

@benley benley commented Nov 8, 2019

Motivation for this change

original PR: #71990

The previous update included several errors which broke packages. This
one re-fetched and fixed them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis @terlar

@terlar @benley
melpa-packages: 2019-10-25
fe0f231 
The previous update included several errors which broke packages. This
one re-fetched and fixed them.

(cherry picked from commit 38dc9cb)
@benley benley added 6.topic: emacs 8.has: port to stable A PR already has a backport to the stable release. labels Nov 8, 2019
@adisbladis adisbladis merged commit 8e3698f into NixOS:release-19.09 Nov 9, 2019
@benley benley deleted the benley/melpa-packages-2019-10-25-backport branch November 10, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

Assignees
No one assigned
Labels
6.topic: emacs 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @adisbladis @terlar