podman: 1.6.2 -> 1.6.3 #73016
Closed
podman: 1.6.2 -> 1.6.3 #73016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Nov 8, 2019
There was a problem hiding this comment.
do you mind changing the outputs of podman to:
outputs = [ "out" "man" ];
nothing actually gets written to the outPath but:
$ tree ./result
./result
└── nix-support
└── propagated-build-inputs
1 directory, 1 file
[00:34:06] jon@jon-desktop /home/jon/projects/nixpkgs (fix-isort)
$ realpath ./result
/nix/store/dp6gv8r80rycxx4ryzf8w1v6v093jygx-podman-1.6.3
|
do you mind changing the outputs of podman to:
outputs = [ "out" "man" ];
That breaks the build (also after changing $bin to $out). I'll take a look at that later.
|
|
I think there's debug symbols pointing back to the compiler, if you grep the binary, you will find a store path to go |
There was a problem hiding this comment.
I think there is a man page missing from this release. The commit containers/podman@079164c is not part of v1.6.3. Does this hurt us?
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "slirp4netns"; | ||
| version = "0.3.0"; | ||
| version = "0.4.2"; |
There was a problem hiding this comment.
I hm as an update already in progress here: #67692
Which one do we want to pick?
|
1.7.0 is already in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The slirp4netns change is needed for proper rootless containers to work.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @