Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haproxy: 1.9.8 -> 2.0.8 #73017

Merged
merged 2 commits into from Nov 9, 2019
Merged

haproxy: 1.9.8 -> 2.0.8 #73017

merged 2 commits into from Nov 9, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

New LTS release.

Also add support for the builtin prometheus exporter, so we don't have to use an external service.

The nixos test doesn't complete but currently on unstable all nixos tests are broken...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fuzzy-id

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable shows usage

[3 built, 1 copied (1.5 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73017
1 package were build:
haproxy

@jonringer
Copy link
Contributor

@GrahamcOfBorg test haproxy

@risicle
Copy link
Contributor

risicle commented Nov 9, 2019

nix-review happy, macos 10.13

@jonringer jonringer merged commit 954e234 into NixOS:master Nov 9, 2019
@peterhoeg peterhoeg deleted the u/haproxy branch November 10, 2019 06:12
@peterhoeg peterhoeg restored the u/haproxy branch November 12, 2019 02:24
@peterhoeg peterhoeg deleted the u/haproxy branch February 17, 2020 08:45
@peterhoeg peterhoeg restored the u/haproxy branch February 20, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants