i've addressed some of the failures here
i set withGtk2 = true; where it seemed appropriate (where the source doesn't mention gtk3),
though maybe using wxGTK29 is more appropriate for those?

i also defaulted wxGTK31 to gtk3, nothing was negatively affected.

i'm still seeing these failures

• dolphinEmu; @delroth seems involved in that, perhaps they can offer clarification?
• prusa-slicer; wxWidgets not found
• slade, sladeUnstable; should support gtk3 but can't find it
• wxsqliteplus; is not fixed by setting withGtk2 = true;

and these which are also broken without this PR

• electricsheep
• pcsx2
• salut_a_toi
• sasview

Re: dolphinEmu, the UI was migrated from WX to Qt a few years ago. Unfortunately I don't think any stable release has been tagged since that migration to Qt. I would either keep wxGTK2 or drop dolphinEmu stable from nixpkgs in favor of dolphinEmuMaster.

rigsofrods has a similar problem; master supports GTK 3, but there has not been an official release since 2016. It seems like upstream considered 4.8rc5 to be a stable release. I tried to update it, but ran into a bunch of runtime issues (crashes, missing textures), so I think I'll just have it use GTK2 for now.

I don't know how aggressive we should be in switching to GTK3. Should I apply the patches Debian and Fedora have written to add GTK3 support to the packages that don't officially support it?

I don't know how aggressive we should be in switching to GTK3. Should I apply the patches Debian and Fedora have written to add GTK3 support to the packages that don't officially support it?

@lopsided98 Absolutely, as a gtk maintainer in nixpkgs I'm always glad to come upon these patches where needed 👍 Though if the package appears completely unused and unmaintained, feel free to remove it in a separate PR.

i've resolved the remaining build failures, still here.

i removed slade-git since it's been surpassed by slade stable, a separate PR may be in order, but i'd rather not introduce a failing build with this one and fixing this just to remove it seem silly.

i also added wrapGAppsHook to most since they otherwise aren't usable without a gnome DE

remaining failures (also fail on master)
electricsheep pcsx2 salut_a_toi sasview

@lopsided98 you can drop audacity commit since it was done in #73055

is there a more systemic way to treat this rather than to patch each of them

No, that's simply how packaging gtk3 apps works in nixpkgs. It all revolves around that setup hook.

#86217 moves filezilla to use gtk3 (and thus wxgtk with gtk3 by extension).

wxwidgets 3.0.5 is out as of y'day which also updates gstreamer from 0.10 to 1.0 which would be great move.

@lopsided98 I know that this PR is probably very tiring as a lot is going on the master branch. If you want to break this apart into smaller PRs, it will also make them easier to merge as there's less surface area to test

Yeah, I think that is the only feasible way to move forward with this. We can just make individual packages use GTK3, and then someday go back and change the default.

I don't have a lot of time to work on this right now, but if others want to take commits from this PR and make separate PRs, feel free to go ahead.

I marked this as stale due to inactivity. → More info