Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm_7: disable failing test on armv6l #73084

Merged
merged 1 commit into from Nov 13, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Disables a test that fails on armv6l. https://reviews.llvm.org/D41859 suggests that the failure may be due to the lack of NEON. LLVM 9 may need this same fix, but I probably won't get around to testing it until #71430 is merged, because my only use of LLVM on armv6l is Rust.

This is the error printed by the test:

frem.ll:22:10: error: CHECK: expected string not found in input
; CHECK: Double value: 2.0
         ^
<stdin>:1:1: note: scanning from here
Double value: 0.000000
^
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323 @7c6f434c @dtzWill

@matthewbauer matthewbauer merged commit 1c3deb9 into NixOS:master Nov 13, 2019
@lopsided98 lopsided98 deleted the llvm-7-armv6l branch November 25, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants