Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 954e234b9834
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a8f50f02ccb1
Choose a head ref
  • 5 commits
  • 4 files changed
  • 2 contributors

Commits on Nov 8, 2019

  1. terraform-providers: group individual repo providers

    Marius Bergmann committed Nov 8, 2019
    Copy the full SHA
    206f719 View commit details
    Browse the repository at this point in the history
  2. terraform-providers: fix handling of version/rev in provider list

    I interpreted the purpose of stripping the first character from the 'version'
    argument as an attempt to remove a prefixed 'v' (e.g. 'v1.0.0') from a version
    tag. This works if the tag actually has a 'v' prefix, but also removes the first
    character if version tags are not prefixed (e.g. '1.0.0').
    
    Additionally, the 'v' was added again when specifying the `rev` for
    `fetchFromGitHub` in default.nix. As described above, this did also not work
    when provider repos did not prefix their version tags with 'v'.
    
    I changed the implementation as follows:
    
    - `version` and `rev` are stored inside data.nix
    - `version` is used to declare the nix package version
    - `rev` is used to fetch the proper git ref when building the package
    - for determining `version`, an optional leading 'v' is trimmed from the tag
      name
    
    Now this has the implication that the latest tag must always be a release tag
    when using the `update-all` script, but as the result of running `update-all`
    should always be reviewed before submission, makes this appear a manageable
    tradeoff to me.
    Marius Bergmann committed Nov 8, 2019
    Copy the full SHA
    3ddd53e View commit details
    Browse the repository at this point in the history
  3. terraform-providers: update existing providers

    Marius Bergmann committed Nov 8, 2019
    Copy the full SHA
    610ffc9 View commit details
    Browse the repository at this point in the history
  4. terraform-provider-pass: init at 1.2.1

    Marius Bergmann committed Nov 8, 2019
    Copy the full SHA
    bc0a2ad View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2019

  1. Merge pull request #72939 from mbrgm/update-terraform-providers

    terraform-providers: update and improve update script
    zimbatm committed Nov 9, 2019
    Copy the full SHA
    a8f50f0 View commit details
    Browse the repository at this point in the history