Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sablotron: remove #73126

Merged
merged 1 commit into from Nov 9, 2019
Merged

sablotron: remove #73126

merged 1 commit into from Nov 9, 2019

Conversation

cko
Copy link
Member

@cko cko commented Nov 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@ofborg ofborg bot requested a review from 7c6f434c November 9, 2019 18:26
@jtojnar jtojnar added this to To do in Picking up garbage via automation Nov 9, 2019
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Nov 9, 2019
@7c6f434c 7c6f434c merged commit 05cd691 into NixOS:master Nov 9, 2019
Picking up garbage automation moved this from In progress to Done Nov 9, 2019
@cko cko mentioned this pull request Nov 9, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cko @7c6f434c