[css-text] Fix test and update TestEpectations #20175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 8, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1905549
branch
3 times, most recently
from
df04dd1
to
7bbd2f3
Compare
The test word-break-break-all-inline-006.html is incorrectly defined, as it was agreed in the corresponding CSS WG issue [1]. This CL changes the expected result of the test and updates the TestExpectations accordingly, since it was failing for LayoutNG before. The new expected result matches current LayoutNG's and Gecko's behavior, but it implies that it fails in legacy and WebKit. [1] #19903 Change-Id: Ia31c89f1a4084607fbb29fd0422354b754a092d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905549 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714458}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1905549
branch
from
7bbd2f3
to
3b97287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test word-break-break-all-inline-006.html is incorrectly defined, as
it was agreed in the corresponding CSS WG issue [1].
This CL changes the expected result of the test and updates the
TestExpectations accordingly, since it was failing for LayoutNG before.
The new expected result matches current LayoutNG's and Gecko's behavior,
but it implies that it fails in legacy and WebKit.
[1] #19903
Change-Id: Ia31c89f1a4084607fbb29fd0422354b754a092d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905549
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714458}